[ 
https://issues.apache.org/jira/browse/BEAM-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Janicek updated BEAM-10292:
---------------------------------
    Description: 
*DefaultFilenamePolicy.ParamsCoder* uses simple *StringUtf8Coder* for 
encoding/decoding *DefaultFilenamePolicy.Params*'s *baseFilename* and therefore 
looses information whether *Params.baseFilename* resource ID is file or 
directory.

The result is that it's effectively preventing user to define directory as 
*baseFilename provider* when using dynamic destinations because after 
deserialization it's translated to file.

Solution is easy - use *ResourceIdCoder* for encoding/decoding.

  was:
*DefaultFilenamePolicy.ParamsCoder* uses simple *StringUtf8Coder* for 
encoding/decoding *DefaultFilenamePolicy.Params*'s *baseFilename* and therefore 
looses information whether *Params.baseFilename* resource ID is file or 
directory.

Solution is easy - use *ResourceIdCoder* for encoding/decoding.


> DefaultFilenamePolicy.ParamsCoder loses information whether Params's resource 
> ID is file/directory
> --------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-10292
>                 URL: https://issues.apache.org/jira/browse/BEAM-10292
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: David Janicek
>            Priority: P2
>
> *DefaultFilenamePolicy.ParamsCoder* uses simple *StringUtf8Coder* for 
> encoding/decoding *DefaultFilenamePolicy.Params*'s *baseFilename* and 
> therefore looses information whether *Params.baseFilename* resource ID is 
> file or directory.
> The result is that it's effectively preventing user to define directory as 
> *baseFilename provider* when using dynamic destinations because after 
> deserialization it's translated to file.
> Solution is easy - use *ResourceIdCoder* for encoding/decoding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to