[ 
https://issues.apache.org/jira/browse/BEAM-9650?focusedWorklogId=449498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449498
 ]

ASF GitHub Bot logged work on BEAM-9650:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jun/20 21:19
            Start Date: 22/Jun/20 21:19
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #11582:
URL: https://github.com/apache/beam/pull/11582#discussion_r443832544



##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1529,3 +1530,180 @@ def display_data(self):
         'source': DisplayDataItem(self.source.__class__, label='Read Source'),
         'source_dd': self.source
     }
+
+
+class SDFBoundedSourceReader(PTransform):
+  """A ``PTransform`` that uses SDF to read from each ``BoundedSource`` in a
+  PCollection.
+
+  NOTE: This transform can only be used with beam_fn_api enabled.
+  """
+  class _SDFBoundedSourceRestriction(object):

Review comment:
       This significantly duplicates functionality from 
`_SDFBoundedSourceWrapper` above - do you think you could have a single 
implementation instead of duplicating a lot of this functionality?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 449498)
    Time Spent: 14h  (was: 13h 50m)

> Add consistent slowly changing side inputs support
> --------------------------------------------------
>
>                 Key: BEAM-9650
>                 URL: https://issues.apache.org/jira/browse/BEAM-9650
>             Project: Beam
>          Issue Type: Bug
>          Components: io-ideas
>            Reporter: Mikhail Gryzykhin
>            Priority: P2
>          Time Spent: 14h
>  Remaining Estimate: 0h
>
> Add implementation for slowly changing dimentions based on [design 
> doc](https://docs.google.com/document/d/1LDY_CtsOJ8Y_zNv1QtkP6AGFrtzkj1q5EW_gSChOIvg/edit]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to