[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=182017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182017
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/19 20:02
Start Date: 07/Jan/19 20:02
Worklog Time Spent: 10m
Work Description: RobbeSneyders commented on pull request #7394:
[BEAM-5315] Python 3 port io.textio module
URL: https://github.com/apache/beam/pull/7394#discussion_r245780402
##########
File path: sdks/python/apache_beam/io/filebasedsource_test.py
##########
@@ -87,6 +87,22 @@ class EOL(object):
def write_data(
num_lines, no_data=False, directory=None, prefix=tempfile.template,
eol=EOL.LF):
+ """Writes test data to a temporary file.
+
+ Args:
+ num_lines (int): The number of lines to write.
+ no_data (bool): If :data:`True`, empty lines will be written, otherwise
+ each line will contain a concatenation of b'line' and the line number.
+ directory (str): The name of the directory to create the temporary file in.
+ prefix (str): The prefix to use for the temporary file.
+ eol (int): The line ending to use when writing.
+ :class:`~apache_beam.io.textio_test.EOL` exposes attributes that can be
+ used here to define the eol.
+
+ Returns:
+ Tuple[str, List[str]): A tuple of the filename and a list of the written
Review comment:
You're right. Fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 182017)
Time Spent: 12h 10m (was: 12h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
