[
https://issues.apache.org/jira/browse/BEAM-4634?focusedWorklogId=450000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450000
]
ASF GitHub Bot logged work on BEAM-4634:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/20 20:16
Start Date: 23/Jun/20 20:16
Worklog Time Spent: 10m
Work Description: bamnet commented on a change in pull request #12061:
URL: https://github.com/apache/beam/pull/12061#discussion_r444481248
##########
File path: sdks/go/pkg/beam/io/bigqueryio/bigquery.go
##########
@@ -90,21 +90,27 @@ func Read(s beam.Scope, project, table string, t
reflect.Type) beam.PCollection
// TODO(herohde) 7/13/2017: using * is probably too inefficient. We
could infer
// a focused query from the type.
- return query(s, project, fmt.Sprintf("SELECT * from [%v]", table), t)
+ return query(s, project, fmt.Sprintf("SELECT * from [%v]", table), t,
nil)
+}
+
+// QueryOptions represents additional options for executing a query.
+type QueryOptions struct {
Review comment:
Done.
I agree, this is a cleaner design. I couldn't think of the phrase "variadic
list of functional options" to save my life.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450000)
Time Spent: 40m (was: 0.5h)
> Use Standard SQL in biqueryio transform
> ---------------------------------------
>
> Key: BEAM-4634
> URL: https://issues.apache.org/jira/browse/BEAM-4634
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Eduardo Morales
> Priority: P3
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The bigqueryio transform is currently hard coded to use Legacy SQL. Using the
> newer Standard SQL would allow us to write richer queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
