[
https://issues.apache.org/jira/browse/BEAM-10313?focusedWorklogId=450523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450523
]
ASF GitHub Bot logged work on BEAM-10313:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/20 16:40
Start Date: 24/Jun/20 16:40
Worklog Time Spent: 10m
Work Description: InigoSJ commented on pull request #12074:
URL: https://github.com/apache/beam/pull/12074#issuecomment-648932828
@pabloem
Some questions that I would need help with:
1 - Is the name `CombinerWithoutDefaults` good enough for the parent class?
Am I adding it in the right place?
2 - All my tests passed, but just to double check, am I missing any `*args,
**kwargs` anywhere?
3 - I needed to add `timestamp = 0` in many tests, should I do it as a
global variable? maybe just use 0 without referencing `timestamp`?
4 - Assert at *795*: I used a bigger window (180) so that there's 2 outputs.
Should I keep it as the previous assert that doesn't have windows (i.e., with
one output element)?
5 - Checking the file, I don't see any pydoc that's needed, but maybe you
think I should add something
Thanks a lot for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450523)
Time Spent: 20m (was: 10m)
> Built-in Combiners don't have the option to use without_defaults()
> ------------------------------------------------------------------
>
> Key: BEAM-10313
> URL: https://issues.apache.org/jira/browse/BEAM-10313
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Inigo San Jose Visiers
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When using Windows and a Global Combiner with need to use
> `without_defaults()`, this is not possible when using the built-in combiners
> (except `Mean` as per
> [BEAM-10209|https://issues.apache.org/jira/browse/BEAM-10209])
> Adding the option to use .without_defaults() directly in all built-in
> Combiners would help both the code readability and ease of use.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
