[
https://issues.apache.org/jira/browse/BEAM-10186?focusedWorklogId=450619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450619
]
ASF GitHub Bot logged work on BEAM-10186:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/20 20:39
Start Date: 24/Jun/20 20:39
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#11911:
URL: https://github.com/apache/beam/pull/11911#discussion_r445156490
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
##########
@@ -260,6 +260,46 @@ BundleProcessor get(
}
}
+ @Test
+ public void testTrySplitBeforeBundleDoesNotFail() {
+ ProcessBundleHandler handler =
+ new ProcessBundleHandler(
+ PipelineOptionsFactory.create(),
+ null,
+ beamFnDataClient,
+ null /* beamFnStateClient */,
+ null /* finalizeBundleHandler */,
+ ImmutableMap.of(),
+ new BundleProcessorCache());
+
+ handler.trySplit(
Review comment:
Done.
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
##########
@@ -260,6 +260,46 @@ BundleProcessor get(
}
}
+ @Test
+ public void testTrySplitBeforeBundleDoesNotFail() {
+ ProcessBundleHandler handler =
+ new ProcessBundleHandler(
+ PipelineOptionsFactory.create(),
+ null,
+ beamFnDataClient,
+ null /* beamFnStateClient */,
+ null /* finalizeBundleHandler */,
+ ImmutableMap.of(),
+ new BundleProcessorCache());
+
+ handler.trySplit(
+ BeamFnApi.InstructionRequest.newBuilder()
+ .setInstructionId("999L")
+ .setProcessBundleSplit(
+
BeamFnApi.ProcessBundleSplitRequest.newBuilder().setInstructionId("unknown-id"))
+ .build());
+ }
+
+ @Test
+ public void testProgressBeforeBundleDoesNotFail() throws Exception {
+ ProcessBundleHandler handler =
+ new ProcessBundleHandler(
+ PipelineOptionsFactory.create(),
+ null,
+ beamFnDataClient,
+ null /* beamFnStateClient */,
+ null /* finalizeBundleHandler */,
+ ImmutableMap.of(),
+ new BundleProcessorCache());
+
+ handler.progress(
Review comment:
Done.
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -341,53 +341,52 @@ private void
createRunnerAndConsumersForPTransformRecursively(
throws Exception {
BundleProcessor bundleProcessor =
bundleProcessorCache.find(request.getProcessBundleProgress().getInstructionId());
- if (bundleProcessor == null) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450619)
Time Spent: 3h 10m (was: 3h)
> Send error response to runner when split or progress requests are received
> out of order
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10186
> URL: https://issues.apache.org/jira/browse/BEAM-10186
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We need to send an error to the runner when split requests or progress
> updates are received by the SDK harness before receiving the corresponding
> bundle.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
