[
https://issues.apache.org/jira/browse/BEAM-10219?focusedWorklogId=450737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450737
]
ASF GitHub Bot logged work on BEAM-10219:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/20 00:36
Start Date: 25/Jun/20 00:36
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #12054:
URL: https://github.com/apache/beam/pull/12054#discussion_r445244602
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/SqlTypes.java
##########
@@ -27,4 +28,7 @@ private SqlTypes() {}
/** Beam LogicalType corresponding to ZetaSQL/CalciteSQL DATE type. */
public static final LogicalType<LocalDate, Long> DATE = new Date();
+
+ /** Beam LogicalType corresponding to ZetaSQL/CalciteSQL TIME type. */
+ public static final LogicalType<LocalTime, Long> TIME = new Time();
Review comment:
This is the most important line of this CL for correctness, wanted to
get attention on it early.
ZetaSQL uses a very specific format for this, which roughly matches the
struct in LocalTime:
https://github.com/google/zetasql/blob/79adcd0fe227173e68ed7aa88f580a691ebe82c2/zetasql/public/civil_time.h#L85
It appears the Long base type is an offset in Nanoseconds. Is that
conversion lossless? Is it expensive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450737)
Time Spent: 50m (was: 40m)
> Support ZetaSQL TIME functions in BeamSQL
> -----------------------------------------
>
> Key: BEAM-10219
> URL: https://issues.apache.org/jira/browse/BEAM-10219
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Support *all* TIME functions defined in ZetaSQL (BigQuery Standard SQL). See
> the list of functions below:
> [https://github.com/google/zetasql/blob/master/docs/time_functions.md]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
