[
https://issues.apache.org/jira/browse/BEAM-8133?focusedWorklogId=450932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450932
]
ASF GitHub Bot logged work on BEAM-8133:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/20 10:10
Start Date: 25/Jun/20 10:10
Worklog Time Spent: 10m
Work Description: pawelpasterz commented on a change in pull request
#11956:
URL: https://github.com/apache/beam/pull/11956#discussion_r445451720
##########
File path:
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java
##########
@@ -142,21 +148,27 @@ void runAll(String[] args) throws IOException {
saveSummary(null, configurations, actual, baseline, start, options);
}
- if (options.getExportSummaryToBigQuery()) {
- ImmutableMap<String, String> schema =
- ImmutableMap.<String, String>builder()
- .put("timestamp", "timestamp")
- .put("runtimeSec", "float")
- .put("eventsPerSec", "float")
- .put("numResults", "integer")
- .build();
+ final ImmutableMap<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("timestamp", "timestamp")
+ .put("runtimeSec", "float")
Review comment:
Sure, but I think we need to change wording to `runtimeMs` as well, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 450932)
Time Spent: 10h 10m (was: 10h)
> Create metrics publisher in Java SDK
> ------------------------------------
>
> Key: BEAM-8133
> URL: https://issues.apache.org/jira/browse/BEAM-8133
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Pawel Pasterz
> Priority: P2
> Fix For: Not applicable
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
