[
https://issues.apache.org/jira/browse/BEAM-6350?focusedWorklogId=182342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-182342
]
ASF GitHub Bot logged work on BEAM-6350:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/19 11:41
Start Date: 08/Jan/19 11:41
Worklog Time Spent: 10m
Work Description: dmvk commented on pull request #7399: [BEAM-6350] Reuse
PCollectionView when created in translators
URL: https://github.com/apache/beam/pull/7399#discussion_r245964709
##########
File path:
sdks/java/extensions/euphoria/src/main/java/org/apache/beam/sdk/extensions/euphoria/core/translate/EuphoriaOptions.java
##########
@@ -60,4 +70,13 @@ public TranslatorProvider create(PipelineOptions options) {
AccumulatorProvider.Factory getAccumulatorProviderFactory();
void setAccumulatorProviderFactory(AccumulatorProvider.Factory
accumulatorProviderFactory);
+
+ @Description("Map of known PCollectionViews")
+ @Default.InstanceFactory(DefaultPCollectionViewStoreFactory.class)
+ @JsonIgnore
+ @Internal
+ PViewsStore getPCollectionViewsStore();
+
+ @Internal
+ void setPCollectionViewsStore(PViewsStore pCollectionViewsStore);
Review comment:
I reckon we don't need a separate field in pipeline options. It should be
enough to keep instance property in BHJ Translator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 182342)
> Reuse same PCollectionView when created in translators
> -------------------------------------------------------
>
> Key: BEAM-6350
> URL: https://issues.apache.org/jira/browse/BEAM-6350
> Project: Beam
> Issue Type: Improvement
> Components: dsl-euphoria
> Affects Versions: 2.11.0
> Reporter: Marek Simunek
> Assignee: David Moravek
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If for LeftJoin is used BroadcastHashJoinTranslator then from right side is
> created PCollectionView (as sideInput).
> If we use right side in multiple joins then PCollectionView is created
> multiple times which is not optimal behavior.
> Eg.
> {code:java}
> LeftJoin.of(left, right)..
> LeftJoin.of(anotherLeftPcollection, right)..
> {code}
> For example it will happen when we want to solve skew Join.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
