[
https://issues.apache.org/jira/browse/BEAM-10219?focusedWorklogId=451241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451241
]
ASF GitHub Bot logged work on BEAM-10219:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/20 18:59
Start Date: 25/Jun/20 18:59
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #12054:
URL: https://github.com/apache/beam/pull/12054#discussion_r445774777
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/SqlTypes.java
##########
@@ -27,4 +28,7 @@ private SqlTypes() {}
/** Beam LogicalType corresponding to ZetaSQL/CalciteSQL DATE type. */
public static final LogicalType<LocalDate, Long> DATE = new Date();
+
+ /** Beam LogicalType corresponding to ZetaSQL/CalciteSQL TIME type. */
+ public static final LogicalType<LocalTime, Long> TIME = new Time();
Review comment:
Actually, the ZetaSQL standard calls for those lossy conversions. The
test is failing due to truncation of precision to millisecond. Expected right
answers for this test case:
```
{
"f0_": "00:00:00",
"f1_": "23:59:59.999999",
"f2_": "01:02:03.123456",
"f3_": "01:02:03.123450",
"f4_": "01:02:03.120000",
"f5_": "01:02:03",
"f6_": "01:02:03",
"f7_": "01:02:03",
"f8_": "00:00:00",
"f9_": "13:00:00",
"f10_": "13:00:00",
"f11_": "00:00:00",
"f12_": "23:59:59.999999",
"f13_": "01:02:03.123456",
"f14_": "01:02:03.123450",
"f15_": "01:02:03.120",
"f16_": "01:02:03",
"f17_": "01:02:03",
"f18_": "01:02:03",
"f19_": "00:00:00",
"f20_": "13:00:00",
"f21_": "13:00:00"
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 451241)
Time Spent: 3h 50m (was: 3h 40m)
> Support ZetaSQL TIME functions in BeamSQL
> -----------------------------------------
>
> Key: BEAM-10219
> URL: https://issues.apache.org/jira/browse/BEAM-10219
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Support *all* TIME functions defined in ZetaSQL (BigQuery Standard SQL). See
> the list of functions below:
> [https://github.com/google/zetasql/blob/master/docs/time_functions.md]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
