Kenneth Knowles created BEAM-10326:
--------------------------------------

             Summary: Combine API to increase safety when accumulator is mutated
                 Key: BEAM-10326
                 URL: https://issues.apache.org/jira/browse/BEAM-10326
             Project: Beam
          Issue Type: New Feature
          Components: sdk-java-core
            Reporter: Kenneth Knowles


Combine docs for e.g. {{mergeAccumulators}} say

"only the first accumulator may be modified and returned for efficiency; the 
other accumulators should not be mutated, because they may be shared with other 
code and mutating them could lead to incorrect results or data corruption."

This is fine, but the API is odd: {{AccumT mergeAccumulators(Iterable<AccumT> 
accumulators)}} implies that all accumulators are treated equally.

It has been suggested to create a new one more like {{AccumT 
mergeAccumulators(AccumT mutable, Iterable<AccumT> immutableAccums)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to