[
https://issues.apache.org/jira/browse/BEAM-9335?focusedWorklogId=451323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451323
]
ASF GitHub Bot logged work on BEAM-9335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/20 22:51
Start Date: 25/Jun/20 22:51
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#10900:
URL: https://github.com/apache/beam/pull/10900#discussion_r445880888
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java
##########
@@ -222,6 +226,20 @@ public OutputT expand(InputT input) {
});
externalPCollectionIdMap = externalPCollectionIdMapBuilder.build();
+ Map<Coder, String> externalCoderIdMapBuilder = new HashMap<>();
+ expandedComponents
+ .getPcollectionsMap()
+ .forEach(
+ (pcolId, pCol) -> {
+ try {
+ Coder coder =
rehydratedComponents.getCoder(pCol.getCoderId());
+ externalCoderIdMapBuilder.putIfAbsent(coder,
pCol.getCoderId());
+ } catch (IOException e) {
+ throw new RuntimeException("cannot rehydrate Coder.");
Review comment:
Won't it often be the case that we can't rehydrate the coder, because
it's specific to another SDK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 451323)
Time Spent: 1h 10m (was: 1h)
> update hard-coded coder id when translating Java external transforms
> --------------------------------------------------------------------
>
> Key: BEAM-9335
> URL: https://issues.apache.org/jira/browse/BEAM-9335
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Heejong Lee
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> hard-coded coder id needs to be updated when translating Java external
> transforms. Otherwise pipeline will fail if coder id is reused.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
