[ 
https://issues.apache.org/jira/browse/BEAM-10311?focusedWorklogId=451352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451352
 ]

ASF GitHub Bot logged work on BEAM-10311:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jun/20 00:37
            Start Date: 26/Jun/20 00:37
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on pull request #12095:
URL: https://github.com/apache/beam/pull/12095#issuecomment-649885158


   R: @lostluck 
   
   Ended up being a really small PR. I tried to think of a way to test it (like 
testing that the channel gets set in the DataSource maybe), but it seems too 
specific of an interaction to test, and any test for it would be a bit 
complicated.
   
   For context of what I'm intending when it comes to the actual splitting: The 
idea is the DataSource will receive the restriction tracker from the channel 
when it needs to check progress or perform a split, and then return the 
restriction tracker to the channel when done with it. The goal is to make sure 
there's only one copy of that tracker being sent around, so that nothing else 
is using the tracker when processing is done and the tracker is getting deleted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 451352)
    Time Spent: 20m  (was: 10m)

> Sharing restriction trackers between SDF ProcessElement executor and 
> DataSource
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-10311
>                 URL: https://issues.apache.org/jira/browse/BEAM-10311
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: P2
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Store trackers of elements currently processing in SDF, in a way accessible 
> to other parts of the SDK harness (harness.go, plan.go, datasource.go, etc). 
> This way when a split request comes in to the Plan, we can tell that there's 
> an SDF processing an element and we're able to split within the element.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to