[
https://issues.apache.org/jira/browse/BEAM-10275?focusedWorklogId=451355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451355
]
ASF GitHub Bot logged work on BEAM-10275:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/20 00:41
Start Date: 26/Jun/20 00:41
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #12032:
URL: https://github.com/apache/beam/pull/12032#discussion_r445910583
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py
##########
@@ -86,6 +92,20 @@ def test_parse_pipeline_options(self):
'{"options": {"eam:option:m_option:v":"mock_val"}}').
get_all_options(drop_default=True))
+ @unittest.skip(
+ 'BEAM-10274: type=json.loads pipeline options cannot be parsed in the '
+ 'python SDK harness')
+ def test_parse_json_object(self):
Review comment:
Should we enable this tests after the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 451355)
Time Spent: 40m (was: 0.5h)
> sdk_worker_main.py eagerly parses pipeline options
> --------------------------------------------------
>
> Key: BEAM-10275
> URL: https://issues.apache.org/jira/browse/BEAM-10275
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> sdk_worker_main.py eagerly parses pipeline options beause of the call to
> get_all_options here:
> https://github.com/apache/beam/blob/61b665640d6c0f91751bba59782c0ac6aceacba6/sdks/python/apache_beam/runners/worker/sdk_worker_main.py#L138
> This can cause the worker to crash if any option that can't be read at
> execution is time is used, even if we don't need to access it at execution
> time (e.g. json.loads arguments, described in BEAM-10274)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
