[ 
https://issues.apache.org/jira/browse/BEAM-9890?focusedWorklogId=451776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451776
 ]

ASF GitHub Bot logged work on BEAM-9890:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jun/20 22:31
            Start Date: 26/Jun/20 22:31
    Worklog Time Spent: 10m 
      Work Description: amaliujia commented on a change in pull request #12079:
URL: https://github.com/apache/beam/pull/12079#discussion_r446437758



##########
File path: 
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##########
@@ -383,4 +392,30 @@ public Long extractOutput(Long accum) {
       return accum;
     }
   }
+
+  static class BitAnd<T extends Number> extends CombineFn<T, Long, Long> {
+    @Override
+    public Long createAccumulator() {
+      return -1L;
+    }
+
+    @Override
+    public Long addInput(Long accum, T input) {
+      return accum & input.longValue();

Review comment:
       In fact, I wasn't sure what's the result of `NULL & long` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 451776)
    Time Spent: 1h 40m  (was: 1.5h)

> Support BIT_AND aggregation function in BeamSQL
> -----------------------------------------------
>
>                 Key: BEAM-9890
>                 URL: https://issues.apache.org/jira/browse/BEAM-9890
>             Project: Beam
>          Issue Type: Task
>          Components: dsl-sql, dsl-sql-zetasql
>            Reporter: Rui Wang
>            Assignee: Yuwei Fu
>            Priority: P2
>              Labels: starter
>             Fix For: Not applicable
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Performs a bitwise AND operation on expression and returns the result.
> Supported Argument Types: INT64
> Returned Data Types: INT64
> Examples
> {code:sql}
> SELECT BIT_AND(c) as bit_and FROM UNNEST([0xF001, 0x00A1]) as c;
> +---------+
> | bit_and |
> +---------+
> | 1       |
> +---------+
> {code}
> What is expected: should include both Calcite and ZetaSQL dialects.
> How to test: unit tests
> Reference: 
> https://cloud.google.com/bigquery/docs/reference/standard-sql/aggregate_functions#bit_and



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to