[ 
https://issues.apache.org/jira/browse/BEAM-10224?focusedWorklogId=452703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452703
 ]

ASF GitHub Bot logged work on BEAM-10224:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/20 23:46
            Start Date: 29/Jun/20 23:46
    Worklog Time Spent: 10m 
      Work Description: robinyqiu commented on pull request #12120:
URL: https://github.com/apache/beam/pull/12120#issuecomment-651426652


   The new ZetaSQL `DATE` and `TIME` types use Beam logical types. Currently 
Beam SQL transforms operate on the **base types** of logical types. This 
produces incorrect result because **input types** are often expected. In 
addition, after https://github.com/apache/beam/pull/11074 values of input type 
are stored in `Row`s. I think we should leverage that change to avoid 
unnecessary conversion to base types for better performance, instead of forcing 
the use of base types.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 452703)
    Time Spent: 0.5h  (was: 20m)

> Test using a DATE field in an aggregation
> -----------------------------------------
>
>                 Key: BEAM-10224
>                 URL: https://issues.apache.org/jira/browse/BEAM-10224
>             Project: Beam
>          Issue Type: Task
>          Components: dsl-sql
>            Reporter: Brian Hulette
>            Assignee: Robin Qiu
>            Priority: P2
>              Labels: beam-fixit
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Since logical types are aggregated with their representation type this may be 
> an issue. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to