[
https://issues.apache.org/jira/browse/BEAM-10341?focusedWorklogId=452769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452769
]
ASF GitHub Bot logged work on BEAM-10341:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/20 02:45
Start Date: 30/Jun/20 02:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447375156
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##########
@@ -99,6 +100,10 @@
*/
public abstract void checkDone() throws IllegalStateException;
+ public boolean isBounded() throws NotImplementedException {
Review comment:
Your right in using PCollection.IsBounded would be weird.
The purpose of not using a boolean on PCollection was to make it clear
whether something was bounded or unbounded. Boolean values also require the
person to remember what the contract of the method is.
We can define an enum in RestrictionTracker similar to what we do in
PCollection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 452769)
Time Spent: 2h 10m (was: 2h)
> Support drain in SDF
> --------------------
>
> Key: BEAM-10341
> URL: https://issues.apache.org/jira/browse/BEAM-10341
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
