[
https://issues.apache.org/jira/browse/BEAM-10400?focusedWorklogId=453624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453624
]
ASF GitHub Bot logged work on BEAM-10400:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 19:43
Start Date: 01/Jul/20 19:43
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #12155:
URL: https://github.com/apache/beam/pull/12155#discussion_r448578900
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactory.java
##########
@@ -128,19 +108,6 @@ public void cleanup() throws Exception {
final DoFn<KV<K, InputT>, OutputT> doFn =
application.getTransform().getDoFn();
final DoFnSignature signature =
DoFnSignatures.getSignature(doFn.getClass());
- // If the DoFn is stateful, schedule state clearing.
- // It is semantically correct to schedule any number of redundant clear
tasks; the
- // cache is used to limit the number of tasks to avoid performance
degradation.
- if (signature.stateDeclarations().size() > 0) {
- for (final WindowedValue<?> element : inputBundle.getElements()) {
- for (final BoundedWindow window : element.getWindows()) {
- cleanupRegistry.get(
- AppliedPTransformOutputKeyAndWindow.create(
- application, (StructuralKey<K>) inputBundle.getKey(),
window));
- }
- }
- }
-
Review comment:
This is removed because it is somewhat duplicate to what
StatefulDoFnRunner already does. We can return it back, it is not directly
related to purpose of this PR, it is just a cleanup that I did during bug
hunting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453624)
Time Spent: 0.5h (was: 20m)
> DirectRunner: race condition in watermark update
> ------------------------------------------------
>
> Key: BEAM-10400
> URL: https://issues.apache.org/jira/browse/BEAM-10400
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Affects Versions: 2.23.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
