[
https://issues.apache.org/jira/browse/BEAM-10391?focusedWorklogId=453639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453639
]
ASF GitHub Bot logged work on BEAM-10391:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 20:17
Start Date: 01/Jul/20 20:17
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #12136:
URL: https://github.com/apache/beam/pull/12136#issuecomment-652625495
> Are we sure that gcp.pubsub.PubsubMessage is right and it is Dataflow that
is wrong?
There's also PubsubClient, which checks for null in getAttributeMap:
https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java#L330
I think for this reason a null attribute map will crash a pipeline running
on Dataflow, but not on any other runner.
Really we should just be consistent between PubsubClient and PubsubSink
(Datflow). I think it will be better to make Dataflow more permissive, rather
than changing PubsubClient and possibly breaking non-Dataflow users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453639)
Time Spent: 0.5h (was: 20m)
> PubsubSink in Dataflow worker doesn't check for null attributeMap
> -----------------------------------------------------------------
>
> Key: BEAM-10391
> URL: https://issues.apache.org/jira/browse/BEAM-10391
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
