[
https://issues.apache.org/jira/browse/BEAM-9953?focusedWorklogId=453659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453659
]
ASF GitHub Bot logged work on BEAM-9953:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 21:12
Start Date: 01/Jul/20 21:12
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #12153:
URL: https://github.com/apache/beam/pull/12153#discussion_r448618515
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -920,8 +946,23 @@ private RexNode convertResolvedFunctionCall(
}
for (ResolvedExpr expr : functionCall.getArgumentList()) {
- operands.add(convertRexNodeFromResolvedExpr(expr, columnList,
fieldList));
+ operands.add(
+ convertRexNodeFromResolvedExpr(expr, columnList, fieldList,
outerFunctionArguments));
+ }
+ } else if (funGroup.equals(USER_DEFINED_FUNCTIONS)) {
Review comment:
I see. For Java UDF (without a nested call), it might not go through the
process to convert every of its arguments. But for nested call cases,
especially with builtin functions, it could go through this process.
We can keep current implementation in this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453659)
Time Spent: 1h 50m (was: 1h 40m)
> Beam ZetaSQL supports multiple statements in a query
> ----------------------------------------------------
>
> Key: BEAM-9953
> URL: https://issues.apache.org/jira/browse/BEAM-9953
> Project: Beam
> Issue Type: Task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> One example of multiple statements query:
> {code:java}
> CREATE FUNCTION fun_a (param_1 INT64); SELECT fun_a(10);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
