[
https://issues.apache.org/jira/browse/BEAM-7672?focusedWorklogId=453686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453686
]
ASF GitHub Bot logged work on BEAM-7672:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 22:15
Start Date: 01/Jul/20 22:15
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r448642475
##########
File path: sdks/python/container/boot.go
##########
@@ -170,6 +176,28 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python", args...))
}
+// setup wheel specs according to installed python version
+func setupAcceptableWheelSpecs() error {
+ cmd := exec.Command("python", "-V")
+ stdoutStderr, err := cmd.CombinedOutput()
+ if err != nil {
+ return err
+ }
+ re := regexp.MustCompile(`Python (\d)\.(\d).*`)
+ pyVersions := re.FindStringSubmatch(string(stdoutStderr[:]))
+ if len(pyVersions) != 3 {
+ return fmt.Errorf("cannot get python version with expected
format")
Review comment:
How about we say "Cannot get parse Python version from ..." and append
the output?
##########
File path: sdks/python/container/boot.go
##########
@@ -127,6 +129,10 @@ func main() {
// Guard from concurrent artifact retrieval and installation,
// when called by child processes in a worker pool.
+ if err := setupAcceptableWheelSpecs(); err != nil {
+ log.Fatalf("Failed to setup acceptable wheel specs: %v", err)
Review comment:
I think we should not fail but leave acceptableWhlSpecs as empty in this
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453686)
Time Spent: 3h 50m (was: 3h 40m)
> Accept Py3 wheels in SDK harness container.
> -------------------------------------------
>
> Key: BEAM-7672
> URL: https://issues.apache.org/jira/browse/BEAM-7672
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-harness
> Reporter: Valentyn Tymofieiev
> Assignee: yoshiki obata
> Priority: P3
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Currently we only accept Py27 wheels:
> https://github.com/apache/beam/blob/05900a43de1f380f124c688cd8d804b5133bda64/sdks/python/container/boot.go#L39
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
