[
https://issues.apache.org/jira/browse/BEAM-9709?focusedWorklogId=453707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453707
]
ASF GitHub Bot logged work on BEAM-9709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/20 23:47
Start Date: 01/Jul/20 23:47
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #12154:
URL: https://github.com/apache/beam/pull/12154#discussion_r448672050
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -3724,6 +3690,57 @@ public void testExceptAll() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
}
+
Review comment:
Extra whitespace here.
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -2791,56 +2791,6 @@ public void testTimestampLiteralWithUTCTimeZone() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
}
- @Test
Review comment:
What is the proper location?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453707)
Time Spent: 0.5h (was: 20m)
> timezone off by 8 hours
> -----------------------
>
> Key: BEAM-9709
> URL: https://issues.apache.org/jira/browse/BEAM-9709
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Robin Qiu
> Priority: P4
> Labels: zetasql-compliance
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> two failures in shard 13, one failure in shard 19
> {code}
> Expected: ARRAY<STRUCT<TIMESTAMP>>[{2014-01-31 00:00:00+00}]
> Actual: ARRAY<STRUCT<$col1 TIMESTAMP>>[{2014-01-31 08:00:00+00}],
> {code}
> {code}
> select timestamp(date '2014-01-31')
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
