[
https://issues.apache.org/jira/browse/BEAM-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149790#comment-17149790
]
Beam JIRA Bot commented on BEAM-10051:
--------------------------------------
This issue is assigned but has not received an update in 30 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Misordered check WRT closed data readers.
> -----------------------------------------
>
> Key: BEAM-10051
> URL: https://issues.apache.org/jira/browse/BEAM-10051
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Labels: stale-assigned
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This check
> https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/harness/datamgr.go#L269
> in it's current position prevents the "normal teardown" that the reader
> expects. This means that readers for instructions that terminate early such
> as due to splitting stay resident in memory and never close.
> In practice this is benign as the buffer would already be closed, but with
> streaming this memory leak would become noticable.
> The fix is to move the check to after the sentinel check, and additionally
> check there for early termination to avoid closing the buffer twice.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
