[
https://issues.apache.org/jira/browse/BEAM-10398?focusedWorklogId=453894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453894
]
ASF GitHub Bot logged work on BEAM-10398:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/20 11:15
Start Date: 02/Jul/20 11:15
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448928301
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -170,26 +174,50 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
+ git push origin "${RELEASE_BRANCH}"
+ RELEASE_COMMIT=$(git rev-parse --verify HEAD)
- echo '-------------------Generating Python Artifacts-----------------'
- cd sdks/python
- virtualenv ${LOCAL_PYTHON_VIRTUALENV}
+ echo '-------------------Creating Python Virtualenv-----------------'
+ python3 -m venv ${LOCAL_PYTHON_VIRTUALENV}
Review comment:
Thanks for pointing this out. I wasn't sure which python version I
should use, but since 2 is sunsetting I decided to use 3 . Now I am thinking is
using fstrings was the good idea since it requires 3.6+.
WDYT @tvalentyn ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 453894)
Time Spent: 1h 10m (was: 1h)
> Use GitHub Actions in release process (python)
> ----------------------------------------------
>
> Key: BEAM-10398
> URL: https://issues.apache.org/jira/browse/BEAM-10398
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Labels: python, release
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
