[
https://issues.apache.org/jira/browse/BEAM-10294?focusedWorklogId=453996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453996
]
ASF GitHub Bot logged work on BEAM-10294:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/20 15:03
Start Date: 02/Jul/20 15:03
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##########
@@ -58,13 +57,13 @@ public static void init(SparkPipelineOptions opts,
JavaSparkContext jsc) {
opts.isStreaming()
? Optional.of(new CheckpointDir(opts.getCheckpointDir()))
: Optional.absent();
- MetricsContainerStepMap metricsContainerStepMap = new
MetricsContainerStepMap();
+ SparkMetricsContainerStepMap metricsContainerStepMap = new
SparkMetricsContainerStepMap();
Review comment:
Won't it be enough to just create new instance of
`SparkMetricsContainerStepMap` here but keep the same interface of
`MetricsContainerStepMap` everywhere as it was before get broken? Why do we
need to change it everywhere since `SparkMetricsContainerStepMap ` just
overrides `toString()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 453996)
Time Spent: 1h 10m (was: 1h)
> Beam metrics are unreadable in Spark history server
> ---------------------------------------------------
>
> Key: BEAM-10294
> URL: https://issues.apache.org/jira/browse/BEAM-10294
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: David Janicek
> Priority: P2
> Attachments: image-2020-06-22-13-48-08-880.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Beam metrics shown in Spark history server are not readable. They're rendered
> as JSON which is created from protobuffer defined in *beam_job_api.proto*
> where metric's value is defined as bytes.
> !image-2020-06-22-13-48-08-880.png!
> Similar issue was already addressed and fixed in BEAM-6062 but was broken by
> BEAM-4552.
> Solution could be using *SparkMetricsContainerStepMap* instead of
> *MetricsContainerStepMap* inside *MetricsContainerStepMapAccumulator* as in
> BEAM-6062.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
