[
https://issues.apache.org/jira/browse/BEAM-10306?focusedWorklogId=454076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-454076
]
ASF GitHub Bot logged work on BEAM-10306:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/20 16:39
Start Date: 02/Jul/20 16:39
Worklog Time Spent: 10m
Work Description: kamilwu commented on a change in pull request #12065:
URL: https://github.com/apache/beam/pull/12065#discussion_r449141423
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -147,10 +151,18 @@ def process(self, element, state=state_param):
CounterOperation(
self.number_of_counters, self.number_of_operations)))
+ if self.window:
+ pc = (
+ pc
+ | beam.WindowInto(beam.window.FixedWindows(1))
+ | beam.GroupByKey())
Review comment:
I see. In this case, maybe it'd would worth to measure latency in
GroupByKey Load Test:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/load_tests/group_by_key_test.py?
GroupByKey step is already there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 454076)
Time Spent: 4h 20m (was: 4h 10m)
> Add latency measurement to Python benchmarks
> --------------------------------------------
>
> Key: BEAM-10306
> URL: https://issues.apache.org/jira/browse/BEAM-10306
> Project: Beam
> Issue Type: Task
> Components: benchmarking-py, build-system, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: P2
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> There are currently no latency metrics in the load tests which makes it
> impossible to monitor latency regressions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
