[
https://issues.apache.org/jira/browse/BEAM-10343?focusedWorklogId=454715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-454715
]
ASF GitHub Bot logged work on BEAM-10343:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jul/20 06:48
Start Date: 06/Jul/20 06:48
Worklog Time Spent: 10m
Work Description: purbanow commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r450015267
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java
##########
@@ -25,7 +27,9 @@
import java.util.function.Consumer;
import java.util.stream.Collectors;
import javax.sql.DataSource;
+import org.apache.beam.sdk.io.snowflake.data.SnowflakeTableSchema;
import org.apache.beam.sdk.io.snowflake.enums.CloudProvider;
Review comment:
For now, I would keep it outside of serviceImpl as its easier to see
which cloud providers currently are supported by IO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 454715)
Time Spent: 1.5h (was: 1h 20m)
> Add dispositions for SnowflakeIO.write
> --------------------------------------
>
> Key: BEAM-10343
> URL: https://issues.apache.org/jira/browse/BEAM-10343
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Pawel Urbanowicz
> Assignee: Pawel Urbanowicz
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
