[ 
https://issues.apache.org/jira/browse/BEAM-10283?focusedWorklogId=455203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455203
 ]

ASF GitHub Bot logged work on BEAM-10283:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jul/20 03:13
            Start Date: 07/Jul/20 03:13
    Worklog Time Spent: 10m 
      Work Description: rafi-kamal commented on a change in pull request #12089:
URL: https://github.com/apache/beam/pull/12089#discussion_r450587998



##########
File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadOptions.java
##########
@@ -0,0 +1,73 @@
+package org.apache.beam.sdk.io.gcp.bigtable;

Review comment:
       Done. Thanks for checking the test results btw, I tried to figure out 
what's wrong from the failing tests but couldn't find any error logs or 
stacktraces.

##########
File path: CHANGES.md
##########
@@ -63,6 +63,8 @@
   is experimental. It reads data from BigQuery by exporting data to Avro 
files, and reading those files. It also supports
   reading data by exporting to JSON files. This has small differences in 
behavior for Time and Date-related fields. See
   Pydoc for more information.
+* New overloads for BigtableIO.Read.withKeyRange() and 
BigtableIO.Read.withRowFilter()

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 455203)
    Time Spent: 1h  (was: 50m)

> BigtableIO doesn't support ValueProvider in withKeyRange and withRowFilter 
> methods
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-10283
>                 URL: https://issues.apache.org/jira/browse/BEAM-10283
>             Project: Beam
>          Issue Type: Wish
>          Components: io-java-gcp
>            Reporter: Rafi Kamal
>            Assignee: Rafi Kamal
>            Priority: P2
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> BigtableIO supports specifying a ValueProvider to set the project ID, 
> instance ID, and table. Unfortunatley, it doesn't support ValueProvider if we 
> want to set the key range or row filter. This makes it unusable in 
> parameterized dataflow templates. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to