Matt McDonald created BEAM-10418:
------------------------------------
Summary: Support type hint annotations on CombineFn add_input()
and extract_output()
Key: BEAM-10418
URL: https://issues.apache.org/jira/browse/BEAM-10418
Project: Beam
Issue Type: Improvement
Components: sdk-py-core
Reporter: Matt McDonald
Similar to the tweaks for supporting native type hints on the
{{PTransform.expand()}} method
(https://issues.apache.org/jira/browse/BEAM-10258), it would be beneficial if
the {{CombineFn}} class also received similar treatment, offering a way to
provide type hints through the native Python hinting interface.
Adding hints to the CombineFn's {{add_input()}} and {{extract_output()}}
methods should be sufficient for providing the equivalent behavior of
annotating the class with beam typehint decorators, e.g.,
{code:python}
@beam.typehints.with_input_types(int)
@beam.typehints.with_output_types(bool)
class MyCombineFn(CombineFn):
...
{code}
vs
{code:python}
class MyCombineFn(CombineFn):
def add_input(self, accumulator: float, element: int):
...
def extract_output(self, accumulator: float) -> bool
...
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
