[
https://issues.apache.org/jira/browse/BEAM-10371?focusedWorklogId=455758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455758
]
ASF GitHub Bot logged work on BEAM-10371:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/20 22:48
Start Date: 07/Jul/20 22:48
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12132:
URL: https://github.com/apache/beam/pull/12132#discussion_r451186550
##########
File path: sdks/python/tox.ini
##########
@@ -287,3 +287,12 @@ deps =
commands =
yapf --version
time yapf --diff --parallel --recursive apache_beam
+
+[testenv:py3-dependency-check]
+# TODO: botocore, a part of [interactive], wants docutils<0.16, but Sphinx
+# pulls in the latest docutils. Uncomment this line once botocore does not
+# conflict with Sphinx:
+# extras = docs,test,gcp,aws,interactive,interactive_test
+extras = test,gcp,aws,interactive,interactive_test
+commands =
+ time {toxinidir}/scripts/run_dependency_check.sh
Review comment:
I think you need to add `passenv = WORKSPACE` here, otherwise the script
fails because WORKSPACE isn't set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455758)
Time Spent: 1h (was: 50m)
> :sdks:python:dependencyUpdates should use python 3
> --------------------------------------------------
>
> Key: BEAM-10371
> URL: https://issues.apache.org/jira/browse/BEAM-10371
> Project: Beam
> Issue Type: Task
> Components: dependencies, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Kamil Wasilewski
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently :sdks:python:dependencyUpdates runs
> scripts/run_depenedency_check.sh with python 2. Python 2 is incompatible with
> the interactive extra, and as other libraries drop python 2 support we can't
> get the full picture of our dependencies by running with python 2.
> :dependencyUpdates should use python 3 instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
