[
https://issues.apache.org/jira/browse/BEAM-9792?focusedWorklogId=455803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-455803
]
ASF GitHub Bot logged work on BEAM-9792:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/20 02:14
Start Date: 08/Jul/20 02:14
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451242654
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -893,6 +906,19 @@ public void deleteDataset(String projectId, String
datasetId)
ignoreInsertIds);
}
+ protected GoogleJsonError.ErrorInfo getErrorInfo(IOException e) {
+ GoogleJsonResponseException jsonCause = null;
Review comment:
We can further simplify :)
protected GoogleJsonError.ErrorInfo getErrorInfo(IOException e) {
if (!(e instanceof GoogleJsonResponseException)) {
return null;
}
GoogleJsonError jsonError = ((GoogleJsonResponseException)
e).getDetails();
...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 455803)
Time Spent: 1h 40m (was: 1.5h)
> BigQuery insertAll ignores retry policy for all errors throwing IOException
> ---------------------------------------------------------------------------
>
> Key: BEAM-9792
> URL: https://issues.apache.org/jira/browse/BEAM-9792
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Heejong Lee
> Assignee: Jiadai Xia
> Priority: P2
> Labels: starter
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> BigQuery insertAll ignores retry policy for all errors throwing IOException
> (it retries forever with backoff)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
