[
https://issues.apache.org/jira/browse/BEAM-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738571#comment-16738571
]
Andrew Pilloud commented on BEAM-6401:
--------------------------------------
Was able to reproduce. Investigating further.
{code}
{
final Boolean inp0_ = ((org.apache.beam.sdk.values.Row)
c.element()).getBoolean(0);
c.output(org.apache.beam.sdk.values.Row.withSchema(outputSchema).addValue((org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.runtime.SqlFunctions.isTrue(inp0_)
|| inp0_ == null ? Boolean.TRUE : inp0_ == null ? (Boolean) null :
Boolean.FALSE) != null &&
(org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.runtime.SqlFunctions.toBoolean(inp0_)
|| inp0_ == null) ? 1 : 0).build());
}
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel$CalcFn.processElement(BeamCalcRel.java:249)
Caused by: java.lang.NullPointerException
at
org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.runtime.SqlFunctions.cannotConvert(SqlFunctions.java:1457)
at
org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.runtime.SqlFunctions.toBoolean(SqlFunctions.java:1480)
at SC.eval0(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus.janino.ScriptEvaluator.evaluate(ScriptEvaluator.java:756)
at
org.apache.beam.sdks.java.extensions.sql.repackaged.org.codehaus.janino.ScriptEvaluator.evaluate(ScriptEvaluator.java:748)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel$CalcFn.processElement(BeamCalcRel.java:246)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel$CalcFn$DoFnInvoker.invokeProcessElement(Unknown
Source)
at
org.apache.beam.repackaged.beam_runners_direct_java.runners.core.SimpleDoFnRunner.invokeProcessElement(SimpleDoFnRunner.java:275)
at
org.apache.beam.repackaged.beam_runners_direct_java.runners.core.SimpleDoFnRunner.processElement(SimpleDoFnRunner.java:240)
at
org.apache.beam.repackaged.beam_runners_direct_java.runners.core.SimplePushbackSideInputDoFnRunner.processElementInReadyWindows(SimplePushbackSideInputDoFnRunner.java:78)
at
org.apache.beam.runners.direct.ParDoEvaluator.processElement(ParDoEvaluator.java:207)
at
org.apache.beam.runners.direct.DoFnLifecycleManagerRemovingTransformEvaluator.processElement(DoFnLifecycleManagerRemovingTransformEvaluator.java:54)
at
org.apache.beam.runners.direct.DirectTransformExecutor.processElements(DirectTransformExecutor.java:160)
at
org.apache.beam.runners.direct.DirectTransformExecutor.run(DirectTransformExecutor.java:124)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}
> NullPointerException and regression in BeamCalcRel
> --------------------------------------------------
>
> Key: BEAM-6401
> URL: https://issues.apache.org/jira/browse/BEAM-6401
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Gleb Kanterov
> Assignee: Andrew Pilloud
> Priority: Major
>
> Test case to reproduce:
> {code}
> Schema schema =
> Schema.builder()
> .addNullableField("f0", Schema.FieldType.BOOLEAN)
> .build();
> String sql =
> "SELECT SUM(case when coalesce(f0, true) = true then 1 else 0 end) " +
> "FROM PCOLLECTION";
> List<Row> rows = ImmutableList.of(
> Row.withSchema(schema).addValue(false).build(),
> Row.withSchema(schema).addValue(true).build(),
> Row.withSchema(schema).addValue(null).build());
> PCollection<Row> input = pipeline.apply("rows",
> Create.of(rows).withRowSchema(schema));
>
> PAssert.that(input.apply(SqlTransform.query(sql))).satisfies(matchesScalar(2));
> pipeline.run();
> {code}
> Similar test case doesn't throw NPE, but fails:
> {code}
> Schema schema =
> Schema.builder()
> .addNullableField("f0", Schema.FieldType.BOOLEAN)
> .build();
> String sql =
> "SELECT SUM(case when coalesce(f0, false) = true then 1 else 0 end) "
> +
> "FROM PCOLLECTION";
> List<Row> rows = ImmutableList.of(
> Row.withSchema(schema).addValue(false).build(),
> Row.withSchema(schema).addValue(true).build(),
> Row.withSchema(schema).addValue(null).build());
> PCollection<Row> input = pipeline.apply("rows",
> Create.of(rows).withRowSchema(schema));
>
> PAssert.that(input.apply(SqlTransform.query(sql))).satisfies(matchesScalar(1));
> pipeline.run();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
