[
https://issues.apache.org/jira/browse/BEAM-10007?focusedWorklogId=456310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456310
]
ASF GitHub Bot logged work on BEAM-10007:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/20 19:37
Start Date: 08/Jul/20 19:37
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655715080
Removing the ValueProvider line didn't actually break any Google tests, but
I lost my resolve to remove it. It seems likely it would break some untested
behavior, e.g. display_data uses drop_defaults=True:
https://github.com/apache/beam/blob/f65a18760a07a48c11fe4aff2a48a845df1f522d/sdks/python/apache_beam/options/pipeline_options.py#L328-L329
Instead I pushed d2d4ecb which makes the assertions in sdk_worker_main_test
more specific. I think this is good to go assuming CI passses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456310)
Time Spent: 3h 10m (was: 3h)
> PortableRunner doesn't handle ValueProvider instances when converting
> pipeline options
> --------------------------------------------------------------------------------------
>
> Key: BEAM-10007
> URL: https://issues.apache.org/jira/browse/BEAM-10007
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We attempt to convert ValueProvider instances directly to JSON with
> json_format, leading to errors like the one described in BEAM-9975.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
