[
https://issues.apache.org/jira/browse/BEAM-4553?focusedWorklogId=456582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456582
]
ASF GitHub Bot logged work on BEAM-4553:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/20 12:44
Start Date: 09/Jul/20 12:44
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#12204:
URL: https://github.com/apache/beam/pull/12204#discussion_r452188740
##########
File path:
runners/extensions-java/metrics/src/test/java/org/apache/beam/runners/extensions/metrics/MetricsGraphiteSinkTest.java
##########
@@ -69,20 +69,20 @@ public void testWriteMetricsWithCommittedSupported() throws
Exception {
countDownLatch.await();
String join = String.join("\n", graphiteServer.getMessages());
String regexpr =
- "beam.counter.ns1.n1.committed.value 10 [0-9]+\\n"
- + "beam.counter.ns1.n1.attempted.value 20 [0-9]+\\n"
- + "beam.gauge.ns1.n3.committed.value 100 [0-9]+\\n"
- + "beam.gauge.ns1.n3.attempted.value 120 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.min 5 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.min 3 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.max 8 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.max 9 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.count 2 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.count 4 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.sum 10 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.sum 25 [0-9]+\\n"
- + "beam.distribution.ns1.n2.committed.mean 5.0 [0-9]+\\n"
- + "beam.distribution.ns1.n2.attempted.mean 6.25 [0-9]+";
+ "beam.counter.ns1.n1.s1.committed.value 10 [0-9]+\\n"
Review comment:
What is a reason for this and all other similar changes (`n1` -> `s1`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 456582)
Time Spent: 6h (was: 5h 50m)
> Implement a Graphite sink for the metrics pusher
> ------------------------------------------------
>
> Key: BEAM-4553
> URL: https://issues.apache.org/jira/browse/BEAM-4553
> Project: Beam
> Issue Type: Sub-task
> Components: runner-extensions-metrics
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: P2
> Fix For: 2.8.0
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Today only a REST Http sink that sends raw json metrics using POST request to
> a http server is available. It is more a POC sink. It would be good to code
> the first real metrics sink. Some of the most popular is Graphite.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
