[
https://issues.apache.org/jira/browse/BEAM-10420?focusedWorklogId=457048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457048
]
ASF GitHub Bot logged work on BEAM-10420:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/20 07:48
Start Date: 10/Jul/20 07:48
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12192:
URL: https://github.com/apache/beam/pull/12192#discussion_r452675861
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -661,8 +661,8 @@ def __init__(self, placeholder):
def invoke_process(self,
windowed_value, # type: WindowedValue
- restriction_tracker=None, # type:
Optional[RestrictionTracker]
- watermark_estimator=None, # type:
Optional[WatermarkEstimator]
+ restriction=None,
Review comment:
New type is just 'object' ?
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -661,8 +661,8 @@ def __init__(self, placeholder):
def invoke_process(self,
windowed_value, # type: WindowedValue
- restriction_tracker=None, # type:
Optional[RestrictionTracker]
- watermark_estimator=None, # type:
Optional[WatermarkEstimator]
+ restriction=None,
Review comment:
Mention when this can be None.
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -661,8 +661,8 @@ def __init__(self, placeholder):
def invoke_process(self,
windowed_value, # type: WindowedValue
- restriction_tracker=None, # type:
Optional[RestrictionTracker]
- watermark_estimator=None, # type:
Optional[WatermarkEstimator]
+ restriction=None,
+ watermark_estimator_state=None,
Review comment:
This is a tuple ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 457048)
Time Spent: 1h 50m (was: 1h 40m)
> PerWindowInvoker to handle window observing SplittableDoFns
> -----------------------------------------------------------
>
> Key: BEAM-10420
> URL: https://issues.apache.org/jira/browse/BEAM-10420
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Labels: portability
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently the FnApiDoFnRunner processes each element within it's own window.
> There is an easy optimization where we process the element once if and only
> if the function doesn't observe the window (either directly or indirectly via
> side inputs/state/...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
