[ 
https://issues.apache.org/jira/browse/BEAM-10136?focusedWorklogId=457901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457901
 ]

ASF GitHub Bot logged work on BEAM-10136:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jul/20 08:37
            Start Date: 13/Jul/20 08:37
    Worklog Time Spent: 10m 
      Work Description: piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-657410328


   @chamikaramj @TheNeuralBit  I've made the requested changes. Also, I found 
an utility in JdbcUtil that is able to call proper set method on 
PreparedStatement, so I think there is no need to test it separately anymore 
(there already is a test of this utility). I put BeamRowPreparedStatementSetter 
to JdbcUtil. I had to make the util class public instead of package-private 
because I wanted to have external classes in separate package.
   
   I'll publish the external builder test after this PR is merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 457901)
    Time Spent: 22h  (was: 21h 50m)

> Add cross-language wrapper for Java's JdbcIO Write
> --------------------------------------------------
>
>                 Key: BEAM-10136
>                 URL: https://issues.apache.org/jira/browse/BEAM-10136
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>    Affects Versions: Not applicable
>            Reporter: Piotr Szuberski
>            Assignee: Piotr Szuberski
>            Priority: P2
>              Labels: portability
>             Fix For: Not applicable
>
>          Time Spent: 22h
>  Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Write



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to