[
https://issues.apache.org/jira/browse/BEAM-6326?focusedWorklogId=183727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-183727
]
ASF GitHub Bot logged work on BEAM-6326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/19 14:43
Start Date: 10/Jan/19 14:43
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7453: [BEAM-6326] Fix
portable stateful processing with side input
URL: https://github.com/apache/beam/pull/7453#discussion_r246784437
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkKeyGroupStateInternals.java
##########
@@ -71,8 +71,10 @@
private final Map<String, Tuple2<Coder<?>, Map<String, ?>>>[] stateTables;
public FlinkKeyGroupStateInternals(Coder<K> keyCoder, KeyedStateBackend
keyedStateBackend) {
- this.keyCoder = keyCoder;
- this.keyedStateBackend = keyedStateBackend;
+ this.keyCoder = Preconditions.checkNotNull(keyCoder, "Coder for key must
be provided.");
+ this.keyedStateBackend =
+ Preconditions.checkNotNull(
+ keyedStateBackend, "KeyedStateBackend must not be null. Missing
keyBy call?");
Review comment:
Note: Not strictly necessary but found it would improve the error message
when a keyed stream was expected but keying had not been applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 183727)
Time Spent: 2h 20m (was: 2h 10m)
> Fix test failures in streaming mode of PortableValidatesRunner
> --------------------------------------------------------------
>
> Key: BEAM-6326
> URL: https://issues.apache.org/jira/browse/BEAM-6326
> Project: Beam
> Issue Type: Test
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> As of BEAM-6009, the tests are run separately for batch and streaming. This
> has revealed issues with a couple of tests which need to be addressed.
> The Gradle task is: {{validatesPortableRunnerStreaming}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
