[ 
https://issues.apache.org/jira/browse/BEAM-10114?focusedWorklogId=458047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458047
 ]

ASF GitHub Bot logged work on BEAM-10114:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jul/20 13:23
            Start Date: 13/Jul/20 13:23
    Worklog Time Spent: 10m 
      Work Description: dpcollins-google commented on a change in pull request 
#11919:
URL: https://github.com/apache/beam/pull/11919#discussion_r453645357



##########
File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java
##########
@@ -109,16 +110,33 @@ public void processElement(
   public static class ViaRandomKey<T> extends PTransform<PCollection<T>, 
PCollection<T>> {
     private ViaRandomKey() {}
 
+    private ViaRandomKey(@Nullable Integer numBuckets) {
+      this.numBuckets = numBuckets;
+    }
+

Review comment:
       These are only minor changes to the transform and this is the only file 
not directly related to pubsub lite io that is changed. Given the high latency 
on merging beam PRs and the fact that this change was proposed in this pr (see 
millsd@ comments above), I'd prefer not to.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 458047)
    Time Spent: 8h 20m  (was: 8h 10m)

> Add Pub/Sub Lite IO to beam builtin
> -----------------------------------
>
>                 Key: BEAM-10114
>                 URL: https://issues.apache.org/jira/browse/BEAM-10114
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-gcp
>            Reporter: Daniel Collins
>            Priority: P2
>          Time Spent: 8h 20m
>  Remaining Estimate: 0h
>
> The IO currently lives [on the pubsub lite 
> github|[https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io]]
>  but should be moved to being part of beam.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to