[
https://issues.apache.org/jira/browse/BEAM-9178?focusedWorklogId=458168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458168
]
ASF GitHub Bot logged work on BEAM-9178:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/20 16:02
Start Date: 13/Jul/20 16:02
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #12231:
URL: https://github.com/apache/beam/pull/12231#discussion_r453757456
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
##########
@@ -359,6 +267,43 @@ private void unparseFunctionsUsingInterval(
}
}
+ private void unparseExtractFunctions(
+ SqlWriter writer, SqlCall call, int leftPrec, int rightPrec) {
+ String funName = call.getOperator().getName();
+ int operandCount = call.operandCount();
+ SqlNode tz = null;
Review comment:
nit: Looks like this should be set exactly once below? consider making
it `final SqlNode tz;` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 458168)
Time Spent: 3h 50m (was: 3h 40m)
> Support ZetaSQL TIMESTAMP functions in BeamSQL
> ----------------------------------------------
>
> Key: BEAM-9178
> URL: https://issues.apache.org/jira/browse/BEAM-9178
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Support *all* TIMESTAMP functions defined in ZetaSQL (BigQuery Standard SQL).
> See the full list of functions below:
> [https://cloud.google.com/bigquery/docs/reference/standard-sql/timestamp_functions]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
