[
https://issues.apache.org/jira/browse/BEAM-10239?focusedWorklogId=458356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458356
]
ASF GitHub Bot logged work on BEAM-10239:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/20 23:04
Start Date: 13/Jul/20 23:04
Worklog Time Spent: 10m
Work Description: robinyqiu commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r453995996
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java
##########
@@ -156,7 +156,14 @@ public void unparseCall(
break;
case OTHER_FUNCTION:
String funName = call.getOperator().getName();
- if (FUNCTIONS_USING_INTERVAL.contains(funName)) {
+ if (funName.equals("numeric_literal")) {
+ // self-designed function
Review comment:
Also, could you move this logic to a function
`unparseNumericLiteralWrapperFunction()` like we do in other branches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 458356)
Time Spent: 40m (was: 0.5h)
> Support ZetaSQL NUMERIC type in BeamSQL
> ---------------------------------------
>
> Key: BEAM-10239
> URL: https://issues.apache.org/jira/browse/BEAM-10239
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Support NUMERIC type defined in ZetaSQL (BigQuery Standard SQL). See the list
> of functions below:
> [https://github.com/google/zetasql/blob/master/docs/data-types.md#numeric-type]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
