[ 
https://issues.apache.org/jira/browse/BEAM-10313?focusedWorklogId=458710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458710
 ]

ASF GitHub Bot logged work on BEAM-10313:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/20 15:24
            Start Date: 14/Jul/20 15:24
    Worklog Time Spent: 10m 
      Work Description: InigoSJ commented on pull request #12074:
URL: https://github.com/apache/beam/pull/12074#issuecomment-658244541


   > I don't fully understand the errors that the checks have. It looks the 
error `Failed assert: ['a'] == ['a', 'b']` is the only one but repeated. Not 
sure how my code can affect that if the Combiners_test works fine. I'm going to 
retest just to be sure.
   
   OK, I ran the test on Master and the same error appeared. Checking other PR, 
I see the same issue ([example](https://github.com/apache/beam/pull/12230).
   
   For the Python2_PVR_Flink error (SNAPSHOT 2.24.0), it looks it's happening 
[everywhere](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)
 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 458710)
    Time Spent: 1h 10m  (was: 1h)

> Built-in Combiners don't have the option to use without_defaults()
> ------------------------------------------------------------------
>
>                 Key: BEAM-10313
>                 URL: https://issues.apache.org/jira/browse/BEAM-10313
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Inigo San Jose Visiers
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When using Windows and a Global Combiner with need to use 
> `without_defaults()`, this is not possible when using the built-in combiners 
> (except `Mean` as per  
> [BEAM-10209|https://issues.apache.org/jira/browse/BEAM-10209])
> Adding the option to use .without_defaults() directly in all built-in 
> Combiners would help both the code readability and ease of use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to