[
https://issues.apache.org/jira/browse/BEAM-10239?focusedWorklogId=458980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458980
]
ASF GitHub Bot logged work on BEAM-10239:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/20 21:44
Start Date: 14/Jul/20 21:44
Worklog Time Spent: 10m
Work Description: ZijieSong946 commented on a change in pull request
#12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r454663699
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -805,6 +807,24 @@ private RexNode convertSimpleValueToRexNode(TypeKind kind,
Value value) {
.makeLiteral(
value.getStringValue(),
typeFactory().createSqlType(SqlTypeName.VARCHAR), true);
break;
+ case TYPE_NUMERIC:
+ // Cannot simply call makeExactLiteral() for ZetaSQL NUMERIC type
because later it will be
Review comment:
Make sense. Maybe a design doc is needed for detailed illustration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 458980)
Time Spent: 2h 50m (was: 2h 40m)
> Support ZetaSQL NUMERIC type in BeamSQL
> ---------------------------------------
>
> Key: BEAM-10239
> URL: https://issues.apache.org/jira/browse/BEAM-10239
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Assignee: Zijie Song
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Support NUMERIC type defined in ZetaSQL (BigQuery Standard SQL). See the list
> of functions below:
> [https://github.com/google/zetasql/blob/master/docs/data-types.md#numeric-type]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
