[
https://issues.apache.org/jira/browse/BEAM-10486?focusedWorklogId=459082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459082
]
ASF GitHub Bot logged work on BEAM-10486:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/20 04:35
Start Date: 15/Jul/20 04:35
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12260:
URL: https://github.com/apache/beam/pull/12260#discussion_r454785667
##########
File path: sdks/python/apache_beam/io/restriction_trackers.py
##########
@@ -92,7 +92,8 @@ def __init__(self, offset_range):
self._checkpointed = False
def check_done(self):
- if self._last_claim_attempt < self._range.stop - 1:
+ if (self._range.start != self._range.stop and
+ self._last_claim_attempt < self._range.stop - 1):
Review comment:
`self._last_claim_attempt` could be `None`. You may want to have
`self._range.start != self._range.stop and (self._last_claim_attemp is None or
self._last_claim_attempt < self._range.stop - 1)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 459082)
Time Spent: 40m (was: 0.5h)
> OffsetRestrictionTracker returning invalid split on completed restriction
> -------------------------------------------------------------------------
>
> Key: BEAM-10486
> URL: https://issues.apache.org/jira/browse/BEAM-10486
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After a failed claim attempt, it is expected that the restriction tracker is
> done and any splits should return None.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
