Kenneth Knowles created BEAM-10515:
--------------------------------------

             Summary: Failure / flake in MemoryMonitorTest > detectGCThrashing
                 Key: BEAM-10515
                 URL: https://issues.apache.org/jira/browse/BEAM-10515
             Project: Beam
          Issue Type: Bug
          Components: runner-dataflow
            Reporter: Kenneth Knowles


[https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/12409/testReport/junit/org.apache.beam.runners.dataflow.worker.util/MemoryMonitorTest/detectGCThrashing/]

{code}
java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at 
org.apache.beam.runners.dataflow.worker.util.MemoryMonitorTest.detectGCThrashing(MemoryMonitorTest.java:93)
{code}

This is a bad assertion, as one must read the code to learn anything.

The code snippet is:

{code}
    provider.inGCThrashingState.set(false);
    monitor.waitForThrashingState(false);
    assertTrue(s.tryAcquire(100, TimeUnit.MILLISECONDS));
{code}

This is a timeout acquiring a lock in 100 milliseconds.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to