[
https://issues.apache.org/jira/browse/BEAM-10136?focusedWorklogId=460085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460085
]
ASF GitHub Bot logged work on BEAM-10136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 04:09
Start Date: 17/Jul/20 04:09
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r456207160
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1982,17 +1982,25 @@ class BeamModulePlugin implements Plugin<Project> {
return argList.join(' ')
}
- project.ext.toxTask = { name, tox_env ->
+ project.ext.toxTask = { name, tox_env, needsExpansionServiceJar = false
->
+ project.evaluationDependsOn(":sdks:java:io:expansion-service")
project.tasks.create(name) {
dependsOn 'setupVirtualenv'
dependsOn ':sdks:python:sdist'
+ if (needsExpansionServiceJar) {
+ dependsOn ':sdks:java:io:expansion-service:shadowJar'
+ }
doLast {
// Python source directory is also tox execution workspace, We want
// to isolate them per tox suite to avoid conflict when running
// multiple tox suites in parallel.
project.copy { from project.pythonSdkDeps; into copiedSrcRoot }
-
+ if (needsExpansionServiceJar) {
+ def expansionServiceJar =
project.project(':sdks:java:io:expansion-service').shadowJar.archivePath
+ def expansionServiceDestinationDir =
"${copiedSrcRoot}/sdks/java/io/expansion-service/build/libs"
Review comment:
I understand that we may need it for integration tests (most of those
should run in postcommits), but why precommits/unit-tests-on-tox need it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 460085)
Time Spent: 28h 10m (was: 28h)
> Add cross-language wrapper for Java's JdbcIO Write
> --------------------------------------------------
>
> Key: BEAM-10136
> URL: https://issues.apache.org/jira/browse/BEAM-10136
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 28h 10m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Write
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
