[ 
https://issues.apache.org/jira/browse/BEAM-10422?focusedWorklogId=460092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460092
 ]

ASF GitHub Bot logged work on BEAM-10422:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jul/20 04:42
            Start Date: 17/Jul/20 04:42
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #12195:
URL: https://github.com/apache/beam/pull/12195#discussion_r456214707



##########
File path: 
.test-infra/jenkins/job_PostCommit_Python_Chicago_Taxi_Example_Dataflow.groovy
##########
@@ -19,46 +19,44 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 import CronJobBuilder
+import LoadTestsBuilder
 
-
-// This job runs the Chicago Taxi Example script on Dataflow
-PostcommitJobBuilder.postCommitJob(
-    'beam_PostCommit_Python_Chicago_Taxi_Dataflow',
-    'Run Chicago Taxi on Dataflow',
-    'Google Cloud Dataflow Runner Chicago Taxi Example',
-    this
-) {
-    description('Runs the Chicago Taxi Example on the Dataflow runner.')
+def chicagoTaxiJob = { scope ->
+    scope.description('Runs the Chicago Taxi Example on the Dataflow runner.')
 
     // Set common parameters.
-    commonJobProperties.setTopLevelMainJobProperties(delegate)
+    commonJobProperties.setTopLevelMainJobProperties(scope)
+
+    def pipelineOptions = [
+        num_workers          : 5,
+        autoscaling_algorithm: 'NONE',
+    ]
 
     // Gradle goals for this job.
-    steps {
+    scope.steps {
         gradle {
             rootBuildScriptDir(commonJobProperties.checkoutDir)
+            commonJobProperties.setGradleSwitches(delegate)
             tasks(':sdks:python:test-suites:dataflow:py2:chicagoTaxiExample')

Review comment:
       Can we switch this to Py3?

##########
File path: 
.test-infra/jenkins/job_PostCommit_Python_Chicago_Taxi_Example_Dataflow.groovy
##########
@@ -19,46 +19,44 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder
 import CronJobBuilder
+import LoadTestsBuilder
 
-
-// This job runs the Chicago Taxi Example script on Dataflow
-PostcommitJobBuilder.postCommitJob(
-    'beam_PostCommit_Python_Chicago_Taxi_Dataflow',
-    'Run Chicago Taxi on Dataflow',
-    'Google Cloud Dataflow Runner Chicago Taxi Example',
-    this
-) {
-    description('Runs the Chicago Taxi Example on the Dataflow runner.')
+def chicagoTaxiJob = { scope ->
+    scope.description('Runs the Chicago Taxi Example on the Dataflow runner.')
 
     // Set common parameters.
-    commonJobProperties.setTopLevelMainJobProperties(delegate)
+    commonJobProperties.setTopLevelMainJobProperties(scope)
+
+    def pipelineOptions = [
+        num_workers          : 5,
+        autoscaling_algorithm: 'NONE',
+    ]
 
     // Gradle goals for this job.
-    steps {
+    scope.steps {
         gradle {
             rootBuildScriptDir(commonJobProperties.checkoutDir)
+            commonJobProperties.setGradleSwitches(delegate)
             tasks(':sdks:python:test-suites:dataflow:py2:chicagoTaxiExample')
             switches('-PgcsRoot=gs://temp-storage-for-perf-tests/chicago-taxi')
+            
switches("-PpipelineOptions=\"${LoadTestsBuilder.parseOptions(pipelineOptions)}\"")
         }
     }
 }
 
+PostcommitJobBuilder.postCommitJob(
+    'beam_PostCommit_Python_Chicago_Taxi_Dataflow',
+    'Run Chicago Taxi on Dataflow',
+    'Google Cloud Dataflow Runner Chicago Taxi Example',
+    this
+) {
+    chicagoTaxiJob(delegate)
+}
+
 CronJobBuilder.cronJob(

Review comment:
       With CronJobBuilder and PostcommitJobBuilder, do we run these test as 
frequent as specified by Cron config or more frequently (as often as new 
commits come in) ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 460092)
    Time Spent: 1h 20m  (was: 1h 10m)

> Python Chicago Taxi Jobs are failing
> ------------------------------------
>
>                 Key: BEAM-10422
>                 URL: https://issues.apache.org/jira/browse/BEAM-10422
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Valentyn Tymofieiev
>            Assignee: Kamil Wasilewski
>            Priority: P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [~kamilwu], can you please take a look?
> https://ci-beam.apache.org/job/beam_PostCommit_Python_Chicago_Taxi_Flink_PR/20/console
> https://ci-beam.apache.org/job/beam_PostCommit_Python_Chicago_Taxi_Dataflow_PR/32/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to