[
https://issues.apache.org/jira/browse/BEAM-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159982#comment-17159982
]
Jayendra edited comment on BEAM-10497 at 7/17/20, 3:19 PM:
-----------------------------------------------------------
[~kenn] I have started working on this and there are ~100 errors regarding this
Null-type checking. As of now, I have two questions.
# Which {{Nullable}} should I use from {{javax.annotation}} or from
{{org.checkerframework}} which you used
[here|https://github.com/apache/beam/pull/12272/commits/3f68f26bb059d981b57d222ebd3f947ea6d3b421]
?
# Should location string
[here|https://github.com/apache/beam/blob/v2.23.0-RC1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/Table.java#L40]
be {{Nullable}} ? if yes what should be the behavior of this MongoDbTable
Constructor
[here|https://github.com/apache/beam/blob/v2.23.0-RC1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/mongodb/MongoDbTable.java#L91]
I think we should throw there InvalidTableException. There are some other
places where we need this for example while constructing AvroTable.
Also is there any instant messing application for communication like
slack/gitter or hipchat for this project?
was (Author: jayendra13):
[~kenn] I have started working on this and there are ~100 errors regarding this
Null-type checking. As of now, I have two questions.
# Which Nullable should I use from javax.annotation or from
org.checkerframework which you used
[here|https://github.com/apache/beam/pull/12272/commits/3f68f26bb059d981b57d222ebd3f947ea6d3b421]
?
# Should location string
[here|https://github.com/apache/beam/blob/v2.23.0-RC1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/Table.java#L40]
be Nullable ? if yes what should be the behaviour of this MongoDbTable
Constructor
[here|https://github.com/apache/beam/blob/v2.23.0-RC1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/mongodb/MongoDbTable.java#L91]
I think we should throw there InvalidTableException.
Also is there any instant messing application for communication like
slack/gitter or hipchat for this project?
> Eliminate nullability errors from :sdks:java:extensions:sql
> -----------------------------------------------------------
>
> Key: BEAM-10497
> URL: https://issues.apache.org/jira/browse/BEAM-10497
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Jayendra
> Priority: P2
> Labels: starter
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
