[
https://issues.apache.org/jira/browse/BEAM-9968?focusedWorklogId=460534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460534
]
ASF GitHub Bot logged work on BEAM-9968:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 21:06
Start Date: 17/Jul/20 21:06
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #12305:
URL: https://github.com/apache/beam/pull/12305#discussion_r456674476
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
##########
@@ -310,6 +312,9 @@ public ActiveBundle newBundle(
private final BundleSplitHandler splitHandler;
private final BundleCheckpointHandler checkpointHandler;
private final BundleFinalizationHandler finalizationHandler;
+ private final Phaser outstandingRequests;
+ private final AtomicBoolean isClosed;
+ private boolean bundleIsCompleted;
Review comment:
Looks like the answer is no because `synchronized` blocks flush caches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 460534)
Time Spent: 1h (was: 50m)
> beam_PreCommit_Java_Cron
> org.apache.beam.runners.fnexecution.control.RemoteExecutionTest.testSplit
> Failure
> ----------------------------------------------------------------------------------------------------------
>
> Key: BEAM-9968
> URL: https://issues.apache.org/jira/browse/BEAM-9968
> Project: Beam
> Issue Type: Bug
> Components: runner-core, test-failures
> Reporter: Kenneth Knowles
> Assignee: Luke Cwik
> Priority: P1
> Labels: currently-failing, flake
> Time Spent: 1h
> Remaining Estimate: 0h
>
> _Use this form to file an issue for test failure:_
> * [https://builds.apache.org/job/beam_PreCommit_Java_Cron/2741/]
> * [https://gradle.com/s/ij5a4z7nhwjn2]
> *
> [RemoteExecutionTest.testSplit](https://github.com/apache/beam/blob/820f0f5c12146195ed80617763a354ddb75f0bc1/runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java#L1358)
> Failure is: `AssertionError` since an assertion was used without a meaningful
> error message. It is asserting that the splits are non-empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
