[
https://issues.apache.org/jira/browse/BEAM-8057?focusedWorklogId=460584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-460584
]
ASF GitHub Bot logged work on BEAM-8057:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/20 22:35
Start Date: 17/Jul/20 22:35
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #12292:
URL: https://github.com/apache/beam/pull/12292#issuecomment-660365698
Yeah that is definitely a better approach. However checking of
`isDeterministic()` in `RexSimplify`
(https://github.com/apache/calcite/blob/551e3f5a182a48e20586e40c378224bb63e4bfb3/core/src/main/java/org/apache/calcite/rex/RexSimplify.java#L334)
is only enabled in Calcite 1.23.0 (See
https://issues.apache.org/jira/browse/CALCITE-3809).
So how about we use the old approach for now, and create a JIRA for updating
to the new approach after we update to 1.23? (The JIRA should be marked blocked
by: https://issues.apache.org/jira/browse/BEAM-9379 (we should change 1.22 to
1.23)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 460584)
Time Spent: 4h 20m (was: 4h 10m)
> Support NAN, INF, and -INF
> --------------------------
>
> Key: BEAM-8057
> URL: https://issues.apache.org/jira/browse/BEAM-8057
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Priority: P3
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
