[
https://issues.apache.org/jira/browse/BEAM-10398?focusedWorklogId=461447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-461447
]
ASF GitHub Bot logged work on BEAM-10398:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/20 08:09
Start Date: 21/Jul/20 08:09
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r457914648
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -154,41 +155,67 @@ if [[ $confirmation = "y" ]]; then
rm -rf ~/${LOCAL_JAVA_STAGING_DIR}
fi
-echo "[Current Step]: Stage python binaries"
+
+echo "[Current Step]: Stage python binaries and wheels"
+echo "===============================Pre-requirements========================"
+echo "Please make sure you have configured and started your gpg by running
./preparation_before_release.sh."
echo "Do you want to proceed? [y|N]"
read confirmation
if [[ $confirmation = "y" ]]; then
echo "============Staging Python Binaries on dist.apache.org========="
cd ~
- if [[ -d ${LOCAL_PYTHON_STAGING_DIR} ]]; then
- rm -rf ${LOCAL_PYTHON_STAGING_DIR}
+ if [[ -d "${LOCAL_PYTHON_STAGING_DIR}" ]]; then
+ rm -rf "${LOCAL_PYTHON_STAGING_DIR}"
fi
- mkdir -p ${LOCAL_PYTHON_STAGING_DIR}
- cd ${LOCAL_PYTHON_STAGING_DIR}
+ mkdir -p "${LOCAL_PYTHON_STAGING_DIR}"
+ cd "${LOCAL_PYTHON_STAGING_DIR}"
echo '-------------------Cloning Beam Release Branch-----------------'
- git clone ${GIT_REPO_URL}
- cd ${BEAM_ROOT_DIR}
- git checkout ${RELEASE_BRANCH}
+ git clone "${GIT_REPO_URL}"
+ cd "${BEAM_ROOT_DIR}"
+ git checkout "${RELEASE_BRANCH}"
+ git push origin "${RELEASE_BRANCH}"
Review comment:
Good point. It is unnecessary, I will delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 461447)
Time Spent: 6h 20m (was: 6h 10m)
> Use GitHub Actions in release process (python)
> ----------------------------------------------
>
> Key: BEAM-10398
> URL: https://issues.apache.org/jira/browse/BEAM-10398
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Tobiasz Kedzierski
> Assignee: Tobiasz Kedzierski
> Priority: P2
> Labels: python, release
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
